This repository was archived by the owner on Oct 22, 2020. It is now read-only.
Added direct attribute and used $parse for event handling#2
Open
rikkertkoppes wants to merge 9 commits intodump247:masterfrom
Open
Added direct attribute and used $parse for event handling#2rikkertkoppes wants to merge 9 commits intodump247:masterfrom
rikkertkoppes wants to merge 9 commits intodump247:masterfrom
Conversation
added 9 commits
March 20, 2013 12:56
…need for pressing a modifier key for multiple select
…able that can be used as an argument use selected($scope) to be able to pass scope as argument. It is still available as the function scope (this)
…o mimic ng-cklick and friends
…ate, or `$selected` as default property
Author
|
Also added an option to redefine the property that is used as <li select="onSelect($event)"
selected="item.selected">
</li>Looking at the code, this has been the intention thus far, but never implemented |
Owner
|
Looks good. My only comment is that I don't really like having a separate multiple and direct attributes, where direct only serves to modify multiple and has no meaning without it. It seems like multiple should have different values in this case. For example: "key" (the default, equivalent to "true" and ""), "direct", and "false" (equivalent to no attribute). The values "key" and "direct" don't feel very descriptive, but I can't think of anything better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a direct attribute to be able to prevent the need for modifier keys. E.g.
will always use multiple selection
Furthermore, the
$eventis now sent along with theselecthandler. This way, one can do